Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to MoQFlvStreamerClient to work with refectored MoQSession + MoQFlvReceiverClient (to test) #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

afrind
Copy link
Contributor

@afrind afrind commented Dec 19, 2024

Summary:
1- Audio track works (group/subg per obj)!!!!
2- Video track crashes the server (different err than before). See below:

...
V1213 09:08:36.445933 925420 MoQSession.cpp:1134] subscribeOk sess=0x51a000013900
V1213 09:08:36.446077 925420 MoQLocation.h:24] m=2
V1213 09:08:36.446148 925420 MoQLocation.h:55] g=0 o=0g=18446744073709551615 o=18446744073709551615
V1213 09:08:37.516494 925420 MoQSession.cpp:1953] onNewUniStream sess=0x51a000011b00
V1213 09:08:37.516966 925420 MoQSession.cpp:643] unidirectionalReadLoop sess=0x51a000011b00
F1213 09:08:37.548959 925420 MoQForwarder.h:270] Check failed: subgroupConsumerIt != sub->subgroups.end()
*** Check failure stack trace: ***
*** Aborted at 1734109717 (Unix time, try 'date -d 1734109717') ***
*** Signal 6 (SIGABRT) (0x3113a000e1e3c) received by PID 925244 (pthread TID 0x7ff6e3600640) (linux TID 925420) (maybe from PID 925244, UID 201018) (code: -6), stack trace: ***
=================================================================
==925244==ERROR: AddressSanitizer: stack-use-after-return on address 0x7ff6e2403a50 at pc 0x7ff6eb667c02 bp 0x7ff6e8e90010 sp 0x7ff6e8e90008
READ of size 8 at 0x7ff6e2403a50 thread T1
SCARINESS: 61 (8-byte-read-stack-use-after-return)
    #0 0x7ff6eb667c01 in folly::AsyncStackRoot::getStackFramePointer() const fbcode/folly/tracing/AsyncStack-inl.h:135
    #1 0x7ff6eb6677d6 in folly::symbolizer::getAsyncStackTraceSafe(unsigned long*, unsigned long) fbcode/folly/debugging/symbolizer/StackTrace.cpp:311
    #2 0x7ff6ed483896 in folly::symbolizer::SafeStackTracePrinter::printStackTrace(bool) fbcode/folly/debugging/symbolizer/Symbolizer.h:91
    #3 0x7ff6ef0b0607 in folly::symbolizer::(anonymous namespace)::innerSignalHandler(int, siginfo_t*, void*) fbcode/folly/debugging/symbolizer/SignalHandler.cpp:453
    #4 0x7ff6ef0aed81 in folly::symbolizer::(anonymous namespace)::signalHandler(int, siginfo_t*, void*) fbcode/folly/debugging/symbolizer/SignalHandler.cpp:474
...

Differential Revision: D66176642

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 19, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66176642

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66176642

afrind pushed a commit to afrind/moxygen that referenced this pull request Dec 25, 2024
…bookexperimental#14)

Summary:

- Adapts MoQFlvStreamerClient to work with MOQ refactored API
- Optimization of MoQFlvStreamerClient

Differential Revision: D66176642
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66176642

afrind pushed a commit to afrind/moxygen that referenced this pull request Dec 25, 2024
…bookexperimental#14)

Summary:

- Adapts MoQFlvStreamerClient to work with MOQ refactored API
- Optimization of MoQFlvStreamerClient

Differential Revision: D66176642
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66176642

…bookexperimental#14)

Summary:

- Adapts MoQFlvStreamerClient to work with MOQ refactored API
- Optimization of MoQFlvStreamerClient

Differential Revision: D66176642
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66176642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants